[PATCH] D67709: [ARM][MVE] Cleanup tail-predicated loop

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Just curious, if the input is already a tail-predicated loop (e.g. coming from intrinsics), would it be possible we incorrectly start removing/inserting things?



================
Comment at: lib/Target/ARM/MVETailPredication.cpp:459
 
+  // Now clean up.
+  SetVector<Instruction*> MaybeDead;
----------------
I wouldn't mind if this is done in a helper function as `TryConvert` is becoming a pretty big function.


================
Comment at: lib/Target/ARM/MVETailPredication.cpp:462
+  for (auto *Pred : Predicates)
+    MaybeDead.insert(cast<Instruction>(Pred));
+
----------------
Do we need the extra `MaybeDead` bookkeeping? Can we just use `Predicates`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67709/new/

https://reviews.llvm.org/D67709