[PATCH] D67785: Use getTargetConstant for BLENDI, and add a test to catch it.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 19:08:07 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll:1
+; ModuleID = 'bugpoint-reduced-simplified.bc'
+source_filename = "complex_single-4eeacc.cpp"
----------------
This can be removed.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll:66
+
+!0 = !{!"clang version google3-trunk (trunk r372353)"}
----------------
llvm.ident can be removed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67785/new/

https://reviews.llvm.org/D67785





More information about the llvm-commits mailing list