[PATCH] D67726: [SampleFDO] Expose an interface to return the size of a section or the size of the profile for profile in ExtBinary format

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 14:02:48 PDT 2019


davidxl added inline comments.


================
Comment at: lib/ProfileData/SampleProfReader.cpp:683
+
+void SampleProfileReaderExtBinaryBase::dumpSectionInfo(raw_ostream &OS) {
+  uint64_t TotalSecsSize = 0;
----------------
Perhaps makes this a virtual function and let the base impl return 'false' (so that caller can warn).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67726/new/

https://reviews.llvm.org/D67726





More information about the llvm-commits mailing list