[PATCH] D67557: [DAG][X86] Convert isNegatibleForFree/GetNegatedExpression to a target hook (PR42863)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 07:15:03 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:41928
+                                           unsigned Depth) const {
+  // fneg patterns are removable even if it has multiple uses.
+  if (isFNEG(DAG, Op.getNode()))
----------------
spatel wrote:
> it has -> they have
grammar nit still here :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67557/new/

https://reviews.llvm.org/D67557





More information about the llvm-commits mailing list