[PATCH] D50231: [llvm-exegesis] Renaming classes and functions.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet marked 3 inline comments as done.
gchatelet added inline comments.


================
Comment at: llvm/trunk/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp:221
 
-TEST_F(UopsSnippetGeneratorTest, MemoryUse) {
+TEST_F(UopsBenchmarkRunnerTest, MemoryUse) {
   // Mov32rm reads from memory.
----------------
yubing wrote:
> yubing wrote:
> > gchatelet wrote:
> > > yubing wrote:
> > > > Hi, gchatelet:
> > > >   I just wonder how to run this testcase. Could you please give us some help?
> > > > 
> > > > Thanks
> > > > 
> > > Sure, the target you want to use is `unittests/tools/llvm-exegesis/X86/all`
> > > Here is the full cmd line I'm using
> > > ```
> > > > cmake -DCMAKE_BUILD_TYPE=Debug -DLLVM_BUILD_TESTS=ON -DBUILD_SHARED_LIBS=ON -DLLVM_USE_SPLIT_DWARF=ON -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_WERROR=ON -H/redacted/git/llvm-project/llvm -B/tmp/llvm-project_dbg_compiled-with-clang -GNinja
> > > > ninja -C /tmp/llvm-project_dbg_compiled-with-clang unittests/tools/llvm-exegesis/X86/all
> > > > /tmp/llvm-project_dbg_compiled-with-clang/unittests/tools/llvm-exegesis/X86/LLVMExegesisX86Tests
> > > ```
> > Hi, gachatelet.
> > Thanks for your answers.
> > I got some trouble when run this test TEST_F(UopsBenchmarkRunnerTest, MemoryUse) :
> > 
> > 
> > ```
> > Expected: has substring "no tied variables"
> >   Actual: "instruction is parallel, repeating a random one."
> > ```
> > 
> > Could you please explain the meaning of the errorlog shown above?
> When I debugged with gdb, I found that MOV32rm's  AllDefRegs and AllUseRegs  has no common elements which lead to this testfail
> But I still don't know  AllDefRegs and AllUseRegs's real meaning.
@yubing would you mind opening a bug on [[ https://bugs.llvm.org/ | buganizer ]] instead? I feel like the patch review is not the right place to debug your issue.
Also, are you sure the code is up to date?
If I open [llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp](https://github.com/llvm/llvm-project/blob/04398c729b20c16aa06bfab4330cf1831d1f8dec/llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp#L292) I can't find `TEST_F(UopsBenchmarkRunnerTest, MemoryUse)` but `TEST_F(UopsSnippetGeneratorTest, MemoryUse)`.

It seems like you're using an old version of the code.



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50231/new/

https://reviews.llvm.org/D50231