[PATCH] D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API.

[Nick Lewycky via Phabricator via llvm-commits]

nickwasmer marked an inline comment as done.
nickwasmer added inline comments.


================
Comment at: llvm/lib/IR/Core.cpp:3643-3645
   Value *P = unwrap<Value>(MemAccessInst);
   if (LoadInst *LI = dyn_cast<LoadInst>(P))
     return LI->isVolatile();
----------------
arsenm wrote:
> Unrelated problem, but this won't catch memory intrinsics with volatile set. I also think there's another copy of this somewhere
> Unrelated problem, but this won't catch memory intrinsics with volatile set. I also think there's another copy of this somewhere

I looked but didn't spot another copy of this logic. If you could point me at it, I'd be happy to use it.

I'm ambivalent about memory intrinsics. The call instruction part of a memory intrinsic doesn't have a concept of volatility.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67132/new/

https://reviews.llvm.org/D67132