[PATCH] D67544: [TableGen] Support encoding and decoding per-HwMode

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 09:16:17 PDT 2019


RKSimon added a comment.

Don't forget to generate diff with context



================
Comment at: llvm/utils/TableGen/CodeEmitterGen.cpp:403
+      if (DefInit *DI = dyn_cast_or_null<DefInit>(RV->getValue())) {
+        auto EBM = EncodingInfoByHwMode(DI->getDef(), HWM);
+        for (auto &KV : EBM.Map) {
----------------
(style) Don't use auto if the type isn't obvious.


================
Comment at: llvm/utils/TableGen/FixedLenDecoderEmitter.cpp:2418
+        auto HWM = Target.getHwModes();
+        auto EBM = EncodingInfoByHwMode(DI->getDef(), HWM);
+        for (auto &KV : EBM.Map) {
----------------
(style) Don't use auto if the type isn't obvious.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67544/new/

https://reviews.llvm.org/D67544





More information about the llvm-commits mailing list