[PATCH] D67700: [Object] Extend MachOUniversalBinary::getObjectForArch

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 09:07:35 PDT 2019


compnerd added inline comments.


================
Comment at: include/llvm/Object/MachOUniversal.h:162
 
-  Expected<std::unique_ptr<MachOObjectFile>>
+  Expected<ObjectForArch>
   getObjectForArch(StringRef ArchName) const;
----------------
`ObjectForArch`?  That seems like an odd type.  Why not use `Binary` if you are looking for a common base type for an object file and an archive?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67700/new/

https://reviews.llvm.org/D67700





More information about the llvm-commits mailing list