[PATCH] D66084: Remove asserts in getLoopGuardBranch

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 09:02:18 PDT 2019


Whitney added inline comments.


================
Comment at: unittests/Analysis/LoopInfoTest.cpp:1157
+  const char *ModuleStr =
+      "target datalayout = \"e-m:o-i64:64-f80:128-n8:16:32:64-S128\"\n"
+      "define void @foo(i32 %n) {\n"
----------------
is this needed?


================
Comment at: unittests/Analysis/LoopInfoTest.cpp:1185
+    BasicBlock *Header = &*(++FI);
+    assert(Header);
+    Loop *L = LI.getLoopFor(Header);
----------------
assert always come with a message.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66084/new/

https://reviews.llvm.org/D66084





More information about the llvm-commits mailing list