[PATCH] D62063: CMake changes to get Windows self-host with PGO working

Russell Gallop via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 07:45:28 PDT 2019


Thanks.

host_ldflags doesn't seem to be used much, but I can't see a reason for it
to not include a particular flag. I think coping with the double quotes
sounds better to me.

Russ

On Wed, 18 Sep 2019 at 15:16, Hans Wennborg via Phabricator <
reviews at reviews.llvm.org> wrote:

> hans added a comment.
>
> > Maybe config.host_ldflags should be using single quotes?
>
> Actually, I'll just do that for now. r372226.
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D62063/new/
>
> https://reviews.llvm.org/D62063
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190918/e127e2dd/attachment.html>


More information about the llvm-commits mailing list