[PATCH] D67690: [LV][NFC] Factor out calculation of "best" estimated trip count.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 01:57:41 PDT 2019


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:372
+    auto TC = getLoopEstimatedTripCount(L);
+    if (TC.hasValue())
+      return TC;
----------------
nit: can simply check `if (TC)`, or fold into

```
  if (Optional<unsigned> TC = getLoopEstimatedTripCount(L))
    return TC;
```
 as done above and below; possibly combining it with the previous if.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67690/new/

https://reviews.llvm.org/D67690





More information about the llvm-commits mailing list