[PATCH] D66991: [PowerPC] Fix SH field overflow issue

Yi-Hong Lyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 22:20:09 PDT 2019


Yi-Hong.Lyu marked 6 inline comments as done.
Yi-Hong.Lyu added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/convert-rr-to-ri-instrs.ll:2
+; RUN: llc -mcpu=pwr9 -O3 -verify-machineinstrs -ppc-asm-full-reg-names < %s | FileCheck %s
+target datalayout = "e-m:e-i64:64-n32:64"
+target triple = "powerpc64le-unknown-linux-gnu"
----------------
amyk wrote:
> We don't need this line, do we?
No longer an issue since MIR doesn't have such field


================
Comment at: llvm/test/CodeGen/PowerPC/convert-rr-to-ri-instrs.ll:3
+target datalayout = "e-m:e-i64:64-n32:64"
+target triple = "powerpc64le-unknown-linux-gnu"
+
----------------
jsji wrote:
> Remove this line as well.
No longer an issue since MIR doesn't have such field


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66991/new/

https://reviews.llvm.org/D66991





More information about the llvm-commits mailing list