[PATCH] D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts.

[Amy Huang via Phabricator via llvm-commits]

akhuang marked 4 inline comments as done.
akhuang added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:4126
+  SmallVector<StringRef, 4> Groups;
+  Regex R("(e-m:[a-z](-p:32:32)?)(-[if]64:.*$)");
+  if (!R.match(DL, &Groups))
----------------
rnk wrote:
> What about -p:64:64 for x64?
I was basing the pattern off of the computeDataLayout function in X86TargetMachine.cpp, which doesn't seem to add -p:64:64. There are a bunch of tests that have -p:64:64:64 in the DL, but I think those wouldn't pass the DL assert anyway if they were in a test case where it matters?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67631/new/

https://reviews.llvm.org/D67631