[PATCH] D67673: [PGO] Change hardcoded thresholds for cold/inlinehint to use summary

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked an inline comment as done.
tejohnson added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1626
 
+  // Add the profile summary (read from the header of the indexed summary) here
+  // so that we can use it below when reading counters (which checks if the
----------------
davidxl wrote:
> Conceptually, this should be set even earlier before getAnalysis at line 1754 below.
I'm not sure what you mean - we can't do so until we create the IndexedInstrProfReader which is just above here, since that reads the header and therefore the summary. Or do you mean that the IndexedInstrProfReader should be created before we call getAnalysis? That would take more restructuring.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67673/new/

https://reviews.llvm.org/D67673