[PATCH] D67645: [aarch64] add def-pats for dot product
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 17 12:37:56 PDT 2019
SjoerdMeijer added a comment.
Many thanks for addressing this!
This pattern matching looks very reasonable to me, just a round of nits:
- was just curious about the `AddedComplexity = 30`
- perhaps I am wrong, but was wondering if clang-format agrees with some of the indentation,
- would some more test bring any benefits/additonal value? Like test with a loops, or tests with no aliasing attributes?
- please ignore if you disagree, but thought that some names like `ldop`, `K1`, `K2` could be slightly more informative/consistent.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67645/new/
https://reviews.llvm.org/D67645
More information about the llvm-commits
mailing list