[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:480
+    for (const auto Sym : CSection.Syms) {
+      writeSymbolTableEntryForSymbol(Sym, CSection, Data,
+                                     Layout.getSymbolOffset(*(Sym.MCSym)));
----------------
xingxue wrote:
> DiggerLin wrote:
> > ditto
> Will follow up when changes in D66969 is updated.
please do not use copy construct here. please  change to for (const auto& Sym : CSection.Syms) {


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125