[PATCH] D67544: [TableGen] Support encoding and decoding per-HwMode

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 06:10:10 PDT 2019


kparzysz added inline comments.


================
Comment at: llvm/utils/TableGen/SubtargetEmitter.cpp:1876
      << " const;\n";
   if (TGT.getHwModes().getNumModeIds() > 1)
     OS << "  unsigned getHwMode() const override;\n";
----------------
This is probably unnecessary with your change.


================
Comment at: llvm/utils/TableGen/SubtargetEmitter.cpp:1934
   EmitSchedModelHelpers(ClassName, OS);
   EmitHwModeCheck(ClassName, OS);
 
----------------
This is probably also unnecessary now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67544/new/

https://reviews.llvm.org/D67544





More information about the llvm-commits mailing list