[PATCH] D67615: [obj2yaml] - Add a support for PPC64 relocations.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: lib/ObjectYAML/ELFYAML.cpp:657
   default:
     llvm_unreachable("Unsupported architecture");
   }
----------------
jhenderson wrote:
> This shouldn't be llvm_unreachable, since it is very reachable...
> 
> It should be, at most, an error instead (though arguably it should just do the enumFallback in that case).
Well, probably yes. But this is original logic and also there is at least one more place with the same thing.
Let me address this in a different patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67615/new/

https://reviews.llvm.org/D67615