[PATCH] D67539: [ARM][LowOverheadLoops] Add LR def safety check

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 00:58:24 PDT 2019


samparker marked an inline comment as done.
samparker added a comment.

For the liveness used here, it's just based upon collecting the live ins from the successor blocks and I though that was okay. Thanks for the iterator suggestions, I'll look into them.



================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:155
+  auto IsMoveLR = [](MachineInstr *MI, unsigned Reg) {
+    return MI->getDesc().isMoveReg() &&
+           MI->getOperand(0).isReg() &&
----------------
dmgreen wrote:
> Is this always just a tMOVr? Would it be better to check that specifically?
sounds good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67539/new/

https://reviews.llvm.org/D67539





More information about the llvm-commits mailing list