[PATCH] D67562: [MemorySSA] Update MSSA for non-conventional AA.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/Analysis/MemorySSA.cpp:1742
 
+  if (!I->mayReadFromMemory() && !I->mayWriteToMemory())
+    return nullptr;
----------------
george.burgess.iv wrote:
> does obviate the need for the recently-added `isa<DbgInfoIntrinsic>()`?
> 
> if so, please add a comment noting that nonstandard AA pipelines might leave us with silly modref results for `I`, so this check is necessary for correctness.
(sorry: please also remove the `isa<DbgInfoIntrinsic>()` above, since it's now redundant :) )


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67562/new/

https://reviews.llvm.org/D67562