[PATCH] D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 14:00:00 PDT 2019


alexshap added a comment.

for what it's worth - i was thinking about it for some time,
it seems to me that using inheritance here would look more complicated + would require a bit more code.
Somehow it feels better to me when there is only one instance of CopyConfig (and it's not moved around).
(yeah, some fields would be populated only when the format of the input is known, but overall this looks kinda simpler to me)
(but i don't want to insist)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67139/new/

https://reviews.llvm.org/D67139





More information about the llvm-commits mailing list