[PATCH] D67628: [compiler-rt][crt] make test case nontrivial in check_cxx_section_exists

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 13:27:50 PDT 2019


jcai19 updated this revision to Diff 220382.
jcai19 added a comment.

Thanks for the comments. I have update my change accordinlgy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67628/new/

https://reviews.llvm.org/D67628

Files:
  compiler-rt/lib/crt/CMakeLists.txt


Index: compiler-rt/lib/crt/CMakeLists.txt
===================================================================
--- compiler-rt/lib/crt/CMakeLists.txt
+++ compiler-rt/lib/crt/CMakeLists.txt
@@ -70,7 +70,8 @@
 endfunction()
 
 check_cxx_section_exists(".init_array" COMPILER_RT_HAS_INITFINI_ARRAY
-  SOURCE "__attribute__((constructor)) void f() {}\nint main() { return 0; }\n")
+  SOURCE "volatile int x;\n__attribute__((constructor)) void f() {x = 0;}\nint main() { return 0; }\n"
+)
 
 append_list_if(COMPILER_RT_HAS_STD_C11_FLAG -std=c11 CRT_CFLAGS)
 append_list_if(COMPILER_RT_HAS_INITFINI_ARRAY -DCRT_HAS_INITFINI_ARRAY CRT_CFLAGS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67628.220382.patch
Type: text/x-patch
Size: 635 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190916/29c832cc/attachment.bin>


More information about the llvm-commits mailing list