[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:153
+      const VFABI::ParsedData PD = OptPD.getValue();
+      const VFShape Shape({PD.VF, PD.IsScalable, PD.ISA, PD.Parameters});
+      return VFInfo({Shape, PD.ScalarName, PD.VectorName});
----------------
Can't tryDemangleForVFABI return a `Optional<VFInfo>` directly? (rather than construct it here from the `ParsedData`)
This also makes me question the need for `ParsedData`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024