[PATCH] D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

> They are different things. I actually don't think that the specification prevents any instructions from being in a TP loop, we just need to be careful of these. We should be able to allow most (all?) of these once we implement some better checks in the backend to look at the operands.

Thanks, make sense, agreed.



================
Comment at: unittests/Target/ARM/MachineInstrTest.cpp:16
+// descriptions. Currently the horizontal vector operations are tagged.
+// TODO Add instructions that perform:
+// - truncation,
----------------
Does this TODO mean we are currently allowing instructions that should not be allowed? If so, is that a problem?


================
Comment at: unittests/Target/ARM/MachineInstrTest.cpp:164
+    ASSERT_EQ(IsInvalidTPOpcode(i), Invalid)
+        << MII->getName(i) << ": missing opcode from test\n";
+    i++;
----------------
Perhaps the message can be a little bit more informative what exactly is wrong here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67444/new/

https://reviews.llvm.org/D67444