[PATCH] D67604: [Attributor] Use Alias Analysis in noalias callsite argument deduction

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I like this, two comments though.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1766
+      AAResults *AAR =
+          A.getInfoCache().getAAResultsForFunction(*getAnchorScope());
+      if (AAR)
----------------
Hoist this as far out as possible.


================
Comment at: llvm/test/Transforms/FunctionAttrs/noalias_returned.ll:266
 ; FIXME: This should be @two_args(i8* noalias %A_0, i8* noalias %B_0)
-; CHECK: tail call void @two_args(i8* %A_0, i8* %B_0)
   tail call void @two_args(i8* %A_0, i8* %B_0)
----------------
Why didn't this get resolved?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67604/new/

https://reviews.llvm.org/D67604