[PATCH] D29121: [Docs] Add LangRef documention for freeze instruction

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Two comments on the diff, the freeze part looks good to me.



================
Comment at: llvm/docs/LangRef.rst:3214
+To ensure all uses of a given register observe the same value (even if
+'``undef``'), the :ref:`freeze instruction <i_freeze>` can be used.
+
----------------
I feel "even if 'undef'" reads as if there is a word missing.


================
Comment at: llvm/docs/LangRef.rst:3318
-Additionally, undefined behavior occurs if a side effect *depends* on poison.
-This includes side effects that are control dependent on a poisoned branch.
 
----------------
Why did we get rid of the side effect on poison is UB stuff here? In the absence of freeze this is still the case, isn't it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29121/new/

https://reviews.llvm.org/D29121