[PATCH] D29121: [Docs] Add LangRef documention for freeze instruction

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Looks good! Some thoughts.



================
Comment at: llvm/docs/LangRef.rst:3110-3111
 
 Undefined Values
 ----------------
 
----------------
Should this section have something similar to the `poison` section, referencing `freeze`?


================
Comment at: llvm/docs/LangRef.rst:3303-3305
 An instruction that *depends* on a poison value, produces a poison value
 itself. A poison value may be relaxed into an
 :ref:`undef value <undefvalues>`, which takes an arbitrary bit-pattern.
----------------
Should this mention `freeze`?


================
Comment at: llvm/docs/LangRef.rst:10176
+.. code-block:: llvm
+
+      %w = i32 undef
----------------
I can see that the scalar restriction was lifter (good)
I think this misses 2 examples:
1. Some trivial vector example
2. An example for `All uses of a '``freeze``' instruction are guaranteed to always observe the same value.`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29121/new/

https://reviews.llvm.org/D29121