[PATCH] D67199: [InstCombine] Expand the simplification of log()

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 15 10:14:37 PDT 2019


xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1788
+  Function *ArgFn = Arg->getCalledFunction();
+  StringRef ArgNm = ArgFn->getName();
+  Intrinsic::ID ArgID = ArgFn->getIntrinsicID();
----------------
ArgFnName?


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1790
+  Intrinsic::ID ArgID = ArgFn->getIntrinsicID();
+  LibFunc ArgLb = NotLibFunc;
+  TLI->getLibFunc(ArgNm, ArgLb);
----------------
ArgLibFn?

Same above. We should use something else than "Lb" I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67199/new/

https://reviews.llvm.org/D67199





More information about the llvm-commits mailing list