[PATCH] D67570: [GlobalISel] Fix insertion point of new instructions to be after PHIs

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 14:13:14 PDT 2019


aemerson created this revision.
aemerson added reviewers: arsenm, paquette, aditya_nandakumar.
Herald added subscribers: Petar.Avramovic, volkan, hiraditya, rovka, nhaehnle, wdng, jvesely.
Herald added a project: LLVM.

For some reason we sometimes insert new instructions one instruction before the first non-PHI when legalizing. This can result in having non-PHI instructions before PHIs, which mean that PHI elimination doesn't catch them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67570

Files:
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/legalize-phi.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-phi.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67570.220171.patch
Type: text/x-patch
Size: 3970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190913/64d7b2dd/attachment.bin>


More information about the llvm-commits mailing list