[PATCH] D67101: Target hooks for custom COPY insertion.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 13:55:06 PDT 2019


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:6422
+        .addReg(Src, 0, SrcSubReg)
+        .addReg(ST.isWave32() ? AMDGPU::EXEC_LO : AMDGPU::EXEC,
+                RegState::Implicit);
----------------
impdef is just exec, you do not need to use exec_lo.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:190
+  MachineBasicBlock::iterator J = std::next(I);
+  if (J != MBB.end() && J->getOpcode() == AMDGPU::S_MOV_B64_term &&
+      J->getOperand(1).isReg() && J->getOperand(1).getReg() == SaveExecReg) {
----------------
S_MOV_B64?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67101/new/

https://reviews.llvm.org/D67101





More information about the llvm-commits mailing list