[PATCH] D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces.

[Eric Christopher via llvm-commits]

I really do think you should just upgrade old layouts to include the
address space.

On Fri, Sep 13, 2019, 11:00 AM Amy Huang via Phabricator <
reviews at reviews.llvm.org> wrote:

> akhuang added a comment.
>
> In D66843#1669803 <https://reviews.llvm.org/D66843#1669803>, @rnk wrote:
>
> > In D66843#1669728 <https://reviews.llvm.org/D66843#1669728>, @kristina
> wrote:
> >
> > > If this is only being used for `clang-cl` (or `-fms-compatibility`)
> mode only, is it possible to limit it to just that rather than it affecting
> pretty much everything?
> >
> >
> > We decided we'd rather not do that. There needs to be some way to
> upgrade the x86 datalayout. It can't be frozen in stone forever.
> >
> > Of course, we need to support the use case of linking old bitcode with
> new bitcode. Doing that probably requires adding an autoupgrade to replace
> the old data layout with the new one when loading bitcode. We already have
> x86-specific intrinsic upgrades in llvm/lib/IR/AutoUpgrade.cpp, so it seems
> reasonable to add this there, even though it is x86 specific, and remove
> the X86TargetMachine change.
>
>
> That sounds good; I can work on a patch for that.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D66843/new/
>
> https://reviews.llvm.org/D66843
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190913/c863d9eb/attachment.html>