[PATCH] D67533: [LNT] Python 3 support: Set up (client) setup requirements

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: requirements.client.txt:15
 pytz==2016.10
-wsgiref==0.1.2
+wsgiref==0.1.2;python_version<"3.0"
 WTForms==2.0.2
----------------
hubert.reinterpretcast wrote:
> thopre wrote:
> > I believe this is part of Python 2.7 already. IMO the first thing to do in porting LNT would be to mandate Python 2.7 or later and add the 'Programming Language :: Python :: 2 :: Only' tag to setup.py
> I believe so too (re: availability of the subject packages in Python 2.7), but I'm not too keen on increasing the possible effects of the patch set. There are more patches necessary to address changes to the behaviour of `import`, text encoding assumptions, etc.
> 
> As for the 'Programming Language :: Python :: 2 :: Only' tag, I'm loath to add it because my use of LNT is limited, meaning that after adding it now, I won't be confident on removing it.
> 
> I'll look into adding `python_requires='>=2.7'` to the `setup` call in this patch.
I missed the implication: We can just remove the two package requirements after mandating Python 2.7 and not maintain different lists for 2.7 and 3. I guess that is enough of a win to make that change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67533/new/

https://reviews.llvm.org/D67533