[PATCH] D67487: [CodeEmitter] Support instruction widths > 64 bits

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 04:03:28 PDT 2019


Hi Roman,

There is one diff to a test and one brand new test in this change
(llvm/test/TableGen/BigEncoder.td). As a sidenote, your message could be
considered by some unnecessarily passive-aggressive.

Cheers,

James

On Fri, 13 Sep 2019 at 11:56, Roman Lebedev via Phabricator <
reviews at reviews.llvm.org> wrote:

> lebedev.ri added a comment.
>
> Can you quote where https://llvm.org/docs/DeveloperPolicy.html#test-cases
> says it's okay to commit dead code with no test coverage?
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67487/new/
>
> https://reviews.llvm.org/D67487
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190913/8598fd66/attachment.html>


More information about the llvm-commits mailing list