[PATCH] D67488: [lib/ObjectYAML] - Change interface to return `bool` instead of `int`. NFCI.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 01:17:16 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: lib/ObjectYAML/yaml2obj.cpp:20
 Error convertYAML(yaml::Input &YIn, raw_ostream &Out, unsigned DocNum) {
-  // TODO: make yaml2* functions return Error instead of int.
-  auto IntToErr = [](int Ret) -> Error {
----------------
sbc100 wrote:
> Is this comment still useful?  
No, since D67445 introduced a different aproach and that is why I removed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67488/new/

https://reviews.llvm.org/D67488





More information about the llvm-commits mailing list