[PATCH] D67404: [ARM] LE support in ConstantIslands

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMConstantIslandPass.cpp:1986
+      Br.MI = NewBR;
+    } else if (&MBB->back() != Br.MI) {
+      MachineInstr &LastMI = MBB->back();
----------------
dmgreen wrote:
> Can you explain this? Is it that we know that this is the LE case, and the other br at the end of the block is being deleted? Can you add a comment.
That's it. But now looking at it again, I'm not sure if Br.MI could actually be LastMI too...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67404/new/

https://reviews.llvm.org/D67404