[PATCH] D67392: [ARM][ParallelDSP] Change smlad insertion order

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 00:39:10 PDT 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:654
+    else
+      V = DT->dominates(cast<Instruction>(A), cast<Instruction>(B)) ? B : A;
+
----------------
efriedma wrote:
> You decided not to modify this dominates() call?
I assumed it wouldn't be worth it... My understanding is that I'd have to create a new ordered block each time, because the block will change after each call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67392/new/

https://reviews.llvm.org/D67392





More information about the llvm-commits mailing list