[PATCH] D67533: [LNT] Python 3 support: Set up (client) setup requirements

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added inline comments.


================
Comment at: lnt/testing/profile/cPerf.cpp:819
+                                     nullptr,
+                                     -1,
+                                     cPerfMethods,
----------------
I think this could be `0` (no space required for module state), but that might be asking for unnecessary trouble.


================
Comment at: setup.py:34
+    if sys.version_info[0] > 2:
+        req_file = "requirements-py3.client.txt"
+    else:
----------------
This is unfortunate, but this `setup.py` is built off of `pip` internal interfaces (which I understand to be a departure from current best practices), and environment markers are not supported by older versions of `pip` anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67533/new/

https://reviews.llvm.org/D67533