[PATCH] D63676: Disable hosting MI to hotter basic blocks

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 19:25:48 PDT 2019


NeHuang marked 5 inline comments as done.
NeHuang added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1572
+
+bool MachineLICMBase::IsHoistingFromColdToHotBlock(MachineBasicBlock *CurBB,
+    MachineBasicBlock *Preheader) {
----------------
lei wrote:
> nit: Most of the functions here use either `BB` or `MBB` for MachineBasicBlock variables.  IMHO unless there are diff BBs that are being tracked, I don't see why we need to specify this as "current"BB.  Just makes it easier to read when similar variables are being used consistently.
Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676





More information about the llvm-commits mailing list