[PATCH] D67497: [aarch64] move custom isel of extract_vector_elt to td file - NFC

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 12:04:46 PDT 2019


SjoerdMeijer added a comment.

The patch looks okay to me, but I am still curious what happens with i16. The lowering to `umov w8, v0.h[1]` in `build-vector-extract.ll` is probably the interesting one. This is probably covered by rule:

  def : Pat<(sext_inreg (vector_extract (v8i16 V128:$Rn), VectorIndexH:$idx),i16),
          (i32 (SMOVvi16to32 V128:$Rn, VectorIndexH:$idx))>;

which is why you don't need the i16 case. But I am not really at my computer, perhaps you can confirm this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67497/new/

https://reviews.llvm.org/D67497





More information about the llvm-commits mailing list