[PATCH] D67506: GSYM: add encoding and decoding to FunctionInfo

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Looks mostly good.



================
Comment at: lib/DebugInfo/GSYM/FunctionInfo.cpp:6
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
----------------
wrong license!


================
Comment at: lib/DebugInfo/GSYM/FunctionInfo.cpp:33
+
+llvm::Expected<FunctionInfo> FunctionInfo::decode(DataExtractor &Data,
+                                                  uint64_t BaseAddr) {
----------------
Thanks, I like that interface!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67506/new/

https://reviews.llvm.org/D67506