[PATCH] D67445: [yaml2obj/ObjectYAML] - Cleanup the error reporting API, add custom errors handlers.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 10:03:48 PDT 2019


sbc100 added inline comments.


================
Comment at: lib/ObjectYAML/MachOEmitter.cpp:69
+  writeLoadCommands(OS);
+  writeSectionData(OS);
 }
----------------
So it seems like this isn't quiet a NFC since the writers in general now always continue to try to write part of the object file even after an error occurs?   This seems slightly worse, although I can't think of case where it would be real problem.    Assuming that is the desired effect and the consequences have been considered then I'm OK with change in general since it does seem the make the core simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67445/new/

https://reviews.llvm.org/D67445





More information about the llvm-commits mailing list