[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 09:36:15 PDT 2019


fpetrogalli added inline comments.


================
Comment at: llvm/lib/Analysis/VFABIDemangling.cpp:413
+                   " of the Vector Function ABI");
+}
----------------
jdoerfert wrote:
> Why is this an `Optional`? It seems to always return a proper VFParamKind if it returns at all.
yeah, sorry,Optional is an unnecessary complication here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024





More information about the llvm-commits mailing list