[PATCH] D67360: [FPEnv] Document that constrained FP intrinsics cannot be mixed with non-constrained

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 08:11:42 PDT 2019


kpn added a comment.

In D67360#1667091 <https://reviews.llvm.org/D67360#1667091>, @uweigand wrote:

> My understanding was that this is a **temporary** restriction; in the end, the goal is to allow mixing constrained an non-constrained operations, once we have the necessary barriers.  Did I misunderstand this?
>
> Now, I guess it still makes sense to document the restriction even if it is temporary, I'm just wondering whether this should be made explicit in the docs.


I can see how knowing that a change to add FP barriers may be coming may affect designs. I believe Serge Pavlov mentioned that he was going to have to "rework" (his word) his patches since he didn't know about the restriction at all. So more information is probably better. I'll update after lunch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67360/new/

https://reviews.llvm.org/D67360





More information about the llvm-commits mailing list