[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Simon Moll via Phabricator via llvm-commits]

simoll requested changes to this revision.
simoll added a comment.
This revision now requires changes to proceed.

One minor thing: VFABI parsing should succeed for any well-formed AVFBI vector function name (beyond what's listed in the `VFISAKind` enum). This would open up the functionality for external users.



================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:50
+  ISA_AVX512,       // x86 AVX512
+  ISA_Invalid       // Unsupported ISA
+};
----------------
How about renaming to `ISA_Unknown` ?


================
Comment at: llvm/lib/Analysis/VFABIDemangling.cpp:302
+
+  if (!getISA(MangledName, PD.ISA))
+    return false;
----------------
Why not carry on with parsing a well-formed AFABI String if the ABI is unknown?
This would enable support for VFABIs not listed here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024