[lld] r371715 - [ELF] Support -z undefs

[Fangrui Song via llvm-commits]

Author: maskray
Date: Thu Sep 12 01:55:17 2019
New Revision: 371715

URL: http://llvm.org/viewvc/llvm-project?rev=371715&view=rev
Log:
[ELF] Support -z undefs

-z undefs is the inverse of -z defs. It allows unresolved references
from object files. This can be used to cancel --no-undefined or -z defs.

Reviewed By: ruiu

Differential Revision: https://reviews.llvm.org/D67479

Modified:
    lld/trunk/ELF/Driver.cpp
    lld/trunk/test/ELF/zdefs.s

Modified: lld/trunk/ELF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=371715&r1=371714&r2=371715&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.cpp (original)
+++ lld/trunk/ELF/Driver.cpp Thu Sep 12 01:55:17 2019
@@ -386,7 +386,7 @@ static bool isKnownZFlag(StringRef s) {
          s == "noexecstack" || s == "nokeep-text-section-prefix" ||
          s == "norelro" || s == "noseparate-code" || s == "notext" ||
          s == "now" || s == "origin" || s == "relro" || s == "retpolineplt" ||
-         s == "rodynamic" || s == "text" || s == "wxneeded" ||
+         s == "rodynamic" || s == "text" || s == "undefs" || s == "wxneeded" ||
          s.startswith("common-page-size") || s.startswith("max-page-size=") ||
          s.startswith("stack-size=");
 }
@@ -517,6 +517,8 @@ static UnresolvedPolicy getUnresolvedSym
     case OPT_z:
       if (StringRef(arg->getValue()) == "defs")
         return errorOrWarn;
+      if (StringRef(arg->getValue()) == "undefs")
+        return UnresolvedPolicy::Ignore;
       continue;
     }
   }

Modified: lld/trunk/test/ELF/zdefs.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/zdefs.s?rev=371715&r1=371714&r2=371715&view=diff
==============================================================================
--- lld/trunk/test/ELF/zdefs.s (original)
+++ lld/trunk/test/ELF/zdefs.s Thu Sep 12 01:55:17 2019
@@ -1,9 +1,15 @@
 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+
+## Unresolved references from object files are allowed by default for -shared.
 # RUN: ld.lld -shared %t.o -o %t1.so
 
+## -z defs disallows unresolved references.
 # RUN: not ld.lld -z defs -shared %t.o -o %t1.so 2>&1 | FileCheck -check-prefix=ERR %s
 # ERR: error: undefined symbol: foo
 # ERR: >>> referenced by {{.*}}:(.text+0x1)
 
+## -z undefs allows unresolved references.
+# RUN: ld.lld -z defs -z undefs -shared %t.o -o /dev/null 2>&1 | count 0
+
 callq foo at PLT