[PATCH] D67482: [ELF][X86] Allow PT_LOAD to have overlapping p_offset ranges on EM_X86_64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 01:43:07 PDT 2019


MaskRay added a comment.

This patch is the (awful) reason I posted D67325 <https://reviews.llvm.org/D67325> before this one. 🤔

The dependency order D67324 <https://reviews.llvm.org/D67324> (omagic & nmagic) -> D67325 <https://reviews.llvm.org/D67325> (image base) -> D67482 <https://reviews.llvm.org/D67482> (EM_X86_64) -> D67481 <https://reviews.llvm.org/D67481> (-z separate-segments) will cause the least number of redundantly updated tests. Say, I do D67482 <https://reviews.llvm.org/D67482> before D67325 <https://reviews.llvm.org/D67325>, the following tests will be updated redundantly.

  Failing Tests (6):                                                                                              
      lld :: ELF/avoid-empty-program-headers.s                                                                    
      lld :: ELF/common-page.s                                                                                    
      lld :: ELF/gnu-ifunc-empty.s                                                                               
      lld :: ELF/image-base.s                                                                                    
      lld :: ELF/linkerscript/page-size.s              
      lld :: ELF/linkerscript/symbol-reserved.s
  ``` 🤔


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67482/new/

https://reviews.llvm.org/D67482





More information about the llvm-commits mailing list