[llvm] r371577 - [Object][TextAPI] NFC, fix tapi lit tests

Cyndy Ishida via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 14:55:24 PDT 2019


Thanks for bringing it to my attention. The patch has been reverted while I investigate and repair. 

- Cyndy Ishida



> On Sep 11, 2019, at 1:46 PM, Galina Kistanova <gkistanova at gmail.com> wrote:
> 
> Hello Cyndy,
> 
> One of your resent commits added broken test to the builder llvm-clang-x86_64-expensive-checks-win.
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19605/steps/test-check-all/logs/stdio <http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19605/steps/test-check-all/logs/stdio>:
> . . .
> Failing Tests (2):
>     . . .
>     LLVM :: Object/nm-tapi.test
>     . . .
> 
> The builder was already red and did not send notifications on this.
> Please have a look?
> 
> Thanks
> 
> Galina
> 
> On Tue, Sep 10, 2019 at 5:11 PM Cyndy Ishida via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: cishida
> Date: Tue Sep 10 17:13:01 2019
> New Revision: 371577
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=371577&view=rev <http://llvm.org/viewvc/llvm-project?rev=371577&view=rev>
> Log:
> [Object][TextAPI] NFC, fix tapi lit tests
> 
> FileCheck command had wrong casing, which works fine on macOS, repairs the linux build bots
> 
> Modified:
>     llvm/trunk/test/Object/nm-tapi-invalids.test
>     llvm/trunk/test/Object/nm-tapi.test
> 
> Modified: llvm/trunk/test/Object/nm-tapi-invalids.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/nm-tapi-invalids.test?rev=371577&r1=371576&r2=371577&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/nm-tapi-invalids.test?rev=371577&r1=371576&r2=371577&view=diff>
> ==============================================================================
> --- llvm/trunk/test/Object/nm-tapi-invalids.test (original)
> +++ llvm/trunk/test/Object/nm-tapi-invalids.test Tue Sep 10 17:13:01 2019
> @@ -1,11 +1,11 @@
>  RUN: not llvm-nm %p/Inputs/tapi-invalid-v1.tbd 2>&1\
> -RUN:          | Filecheck %s -check-prefix v1
> +RUN:          | FileCheck %s -check-prefix v1
> 
>  RUN: not llvm-nm %p/Inputs/tapi-invalid-v2.tbd 2>&1\
> -RUN:          | Filecheck %s -check-prefix v2
> +RUN:          | FileCheck %s -check-prefix v2
> 
>  RUN: not llvm-nm %p/Inputs/tapi-invalid-v3.tbd 2>&1\
> -RUN:          | Filecheck %s -check-prefix v3
> +RUN:          | FileCheck %s -check-prefix v3
> 
>  # Typo Check
>  v1: tapi-invalid-v1.tbd malformed file
> 
> Modified: llvm/trunk/test/Object/nm-tapi.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/nm-tapi.test?rev=371577&r1=371576&r2=371577&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/nm-tapi.test?rev=371577&r1=371576&r2=371577&view=diff>
> ==============================================================================
> --- llvm/trunk/test/Object/nm-tapi.test (original)
> +++ llvm/trunk/test/Object/nm-tapi.test Tue Sep 10 17:13:01 2019
> @@ -1,11 +1,11 @@
>  RUN: llvm-nm %p/Inputs/tapi-v1.tbd 2>&1\
> -RUN:          | Filecheck %s -check-prefix v1
> +RUN:          | FileCheck %s -check-prefix v1
> 
>  RUN: llvm-nm %p/Inputs/tapi-v2.tbd \
> -RUN:          | Filecheck %s -check-prefix v2
> +RUN:          | FileCheck %s -check-prefix v2
> 
>  RUN: llvm-nm %p/Inputs/tapi-v3.tbd \
> -RUN:          | Filecheck %s -check-prefix v3
> +RUN:          | FileCheck %s -check-prefix v3
> 
>  v1: no symbols
>  v1: tapi-v1.tbd (for architecture armv7):
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190911/ba16d417/attachment-0001.html>


More information about the llvm-commits mailing list