[PATCH] D67279: GlobalISel/AMDGPU: Legalize G_FMAD

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 12:58:08 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1298
+  if (Ty == LLT::scalar(32) && !ST.hasFP32Denormals())
+    return true;
+  if (Ty == LLT::scalar(16) && !ST.hasFP16Denormals())
----------------
aditya_nandakumar wrote:
> Won't ignoring this case here result in it failing the checks at the beginning of the instruction select where it probably will assert that this instruction is not legal (as it's custom).
That check asserts isLegalOrCustom


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67279/new/

https://reviews.llvm.org/D67279





More information about the llvm-commits mailing list