[PATCH] D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 12:44:15 PDT 2019


Dor1s added a comment.

In D66107#1666574 <https://reviews.llvm.org/D66107#1666574>, @Hahnfeld wrote:

> In D66107#1666569 <https://reviews.llvm.org/D66107#1666569>, @Dor1s wrote:
>
> > Hm, doesn't fail for me, but I guess the feature detection might be platform-dependent to some extent, so I'm fine with replacing the number of the features with a regex. Do you want to upload a change, or should I?
>
>
> I think the bots are also green, so it might be just related to how I build Clang (with libc++, for example). I'm half way through building ToT with GCC, that should give insight whether it's related to my system or my configuration.


Actually, some ARM bots got broken, so I've uploaded a fix: https://reviews.llvm.org/D67458

> Just curious: So the number of new features and coverage edges does not need to be the same? I also have "15 new freatures" for `CHECK2`.

Yes, features include coverage edges + additional signal (e.g. value profiling), that's why the number is different and why number of features can differ between platforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66107/new/

https://reviews.llvm.org/D66107





More information about the llvm-commits mailing list