[PATCH] D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D66843#1666367 <https://reviews.llvm.org/D66843#1666367>, @echristo wrote:

> Still really not a fan of this way. I think you can change the incoming DL in compatibility cases to add an address space when none exists on x86.
>
> -eric


Is that suggestion to handle it in AutoUpgrade.cpp? My rationale for doing it this way was, if a module lacks these address spaces in data layout, it is old bitcode, and it won't use these address spaces for this purpose. But of course, it's unchecked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66843/new/

https://reviews.llvm.org/D66843